Install view_component and add initial AvatarComponent
#1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1403 +/- ##
==========================================
+ Coverage 95.21% 95.23% +0.02%
==========================================
Files 168 169 +1
Lines 2631 2646 +15
==========================================
+ Hits 2505 2520 +15
Misses 126 126
☔ View full report in Codecov by Sentry. |
pixeldesu
force-pushed
the
feature/avatar-component
branch
from
0138cb2 to
ae4210d
Compare
Merged
nilsding
approved these changes
Oct 21, 2023
raccube
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce logic in views and introduce a better workflow for reusability, we now include
view_component! 🎉This PR also includes an initial
AvatarComponent, with additional accessibility improvements to avatars (altattributes)